Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URIs with single-word hostnames show entire URIs in menu when using strictness of "base domain" #44

Closed
jsamuel opened this issue Dec 22, 2011 · 1 comment
Closed

URIs with single-word hostnames show entire URIs in menu when using strictness of "base domain" #44

jsamuel opened this issue Dec 22, 2011 · 1 comment
Labels
bug report

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011 

imported trac ticket
created: 2009-10-05 09:07:15
reporter: fung0 and Herrminator

If one is using "base domain" strictness, going to a location with a single-word hostname (e.g. "localhost") results in not recognizing a hostname at all.

For example:
http://localhost/phpmyadmin/

results in the following blocked destinations in the menu:

http://localhost/phpmyadmin/favicon.ico
http://localhost/phpmyadmin/pring.css
...

This bug is the result of the refactoring done to modules/DomainUtil.jsm in r274 where I removed the "fall through" of trying to grab a different identifier from the URI if the default level's logic fails.

Original report (same issue noticed by different users):
http://forums.mozillazine.org/viewtopic.php?p=7648765#p7648765
@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011 

imported trac comment
created: 2009-10-06 11:22:01
author: justin

Fixed in r291. It turns out that even though the direct cause of the appearance of this bug was removing the fall-through behavior, the underlying issue was actually a bug in exception handling. The fall-through shouldn't have been needed.

@jsamuel jsamuel closed this as completed Dec 22, 2011
@msxfm msxfm mentioned this issue Jul 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsamuel