imported trac comment
created: 2009-09-16 13:31:32
author: justin

Thanks for providing this bug report, Aja. I started looking into it this morning (saw the mozillazine post of yours) but I still haven't had a chance to look at everything I need to.

Here's what see so far.

The gBrowser.addTab function whose signature looks like this:

{{{
function addTab(aURI, aReferrerURI, aCharset, aPostData, aOwner, aAllowThirdPartyFixup)
}}}

Now seems to be passing an object in the aReferrerURI that looks like this rather than being an nsIURI:

{{{
[object Object]
=> key: referrerURI / value: null
=> key: charset / value: null
=> key: postData / value: null
=> key: ownerTab / value: [object XULElement]
=> key: allowThirdPartyFixup / value: false
=> key: relatedToCurrent / value: undefined
}}}

And the aReferrerURI.referrerURI is what used to be in the aReferrerURI argument.

However, before you think I'm saying it's a change in functionality in Firefox or a bug in Firefox, note the really odd part that the attributes of aReferrerURI look a lot like the arguments that were supposed to be passed to addTab. This makes me think that there may be a bug in RequestPolicy. There's some horrible code related to modifying addTab that I had to use because TabMixPlus has some horrible code for modifying addTab and I couldn't retain compatibility without doing it their way (I'm not sure if they have a good reason for the way they did it, so I'm not judging, just saying it's horrible and I hope it was a last resort).

So, what I need to do when I have time (probably tomorrow morning) is to dig into this more to see if the way addTab() is being called by Firefox has really changed or if this is a side effect of the bad way that I'm wrapping addTab().

imported trac comment
created: 2009-09-16 19:31:48
author: justin

Here is the source of the problem, a change in the tabbrowser.addTab function:

http://hg.mozilla.org/mozilla-central/rev/0137837043e0

https://bugzilla.mozilla.org/show_bug.cgi?id=515932

I'll work on a fix for this in the next day or two.

By the way, I should mention that I didn't mean any offense to the !TabMixPlus folks. I took a look at their code again (it's been a long time since I looked at it) and I'm not sure how they'd do anything differently. As ugly as it is, their hands may be tied. Maybe down the road I'll try to coordinate with them to make it easier for extensions like !RequestPolicy to coexist with !TabMixPlus without having to uglify our code, as well.

imported trac comment
created: 2009-09-18 09:35:41
author: justin

Fixed in r269. Will be included in 0.5.9, possibly released this weekend.