Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening RP Toolbar Menu truncates width of Tree Style Tab tree on FF4 #181

Closed
jsamuel opened this issue Dec 22, 2011 · 6 comments
Closed

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2011-02-05 19:04:56
reporter: eibwen

Firefox 4.0b12 extension compatibility issue

  • Request Policy with toolbar icon
  • Tree Style Tab with tree displayed at right (non-inverted)

Latest AMO versions of each.

When the RP toolbar (not addon-bar) icon is clicked, the width of the Tree Style Tab tree is temporarily truncated. This can be reset quite readily; however, the visual glitch is very annoying.

Does not happen with other toolbar icons that open a menu, including the standard bookmarks icon or other icons from extensions.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-06 01:29:16
author: eibwen

Second issue:

When the request log is shown, it appears under both the browser window and the Tree Style Tab sidebar (as displayed at right). When the tab width is truncated as per the first issue, the tabs are shown above the request log! Trying to click the still visible request log close button, does not close the request log, but instead changes tabs!

Further, when the tabs are truncated, the width is too small to even show a favicon! Users would have to intentionally hover over each tab to identify by tooltip. As such, the tab change seems very random, but is probably whatever tab is horizontally aligned with the click...

The first bug alone is a bearable graphical glitch, as it can be reset, eg by toggling the display of the request log; however, this latter bug is a significant usability issue!

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-06 12:52:46
author: justin

For the first issue, I've seen this behavior as well and I consider it to be a bug in Tree Style Tabs or Firefox 4. That is, RP is not doing anything unusual from what I can tell. Tree Style Tabs has had their work cut out for them in keeping up with Firefox 4 changes. It should be reported to the Tree Style Tabs developer.

For the second issue, I haven't seen this before and I can't repeat it.

For the record, the width glitch can be "fixed" by maximizing/unmaximizing (not minimizing) Firefox. At least, this works on Ubuntu 10.10.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-13 01:44:02
author: eibwen

DOM Inspector indicates that request policy is the only toolbar icon with a submenu that uses the onclick attribute to toggle an overlay (at least of the extensions I have installed). There appear to be a few variations on how to achieve this without an additional overlay, eg:

Perhaps the onclick event, overlay generation, and/or overlay display is resulting in this effect...

Reviewing the code, it looks like request policy is trying to create one menupopup and continually reparent it, depending on how it was opened last -- statusbar, context menu, toolbar icon...

noscript uses menupopup.openPopup(anchor) to make it appear that the menupopup was reparented...

Adblock Plus clones the statusbar menupopup to the toolbar...

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-13 16:47:45
author: justin

I've opened a ticket in the Tree Style Tab issue tracker.

https://github.com/piroor/treestyletab/issues/#issue/45

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-13 18:38:30
author: justin

This has been fixed in Tree Style Tabs.

https://github.com/piroor/treestyletab/issues/#issue/45/comment/768999

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-13 18:40:04
author: justin

By the way, amazing responsiveness from the Tree Style Tab developer. I've opened a ticket for their RP suggestion (#188).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant